Skip to content

[server] Add HLL sketch aggregation merge function - #3337

Merged
platinumhamburg merged 8 commits into
apache:mainfrom
rahulbsw:hll-sketch-aggregation
Nov 12, 2026
Merged

[server] Add HLL sketch aggregation merge function#3337
platinumhamburg merged 8 commits into
apache:mainfrom
rahulbsw:hll-sketch-aggregation

Conversation

@rahulbsw

@rahulbsw rahulbsw commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Test Plan

  • mvn -pl fluss-common,fluss-server,fluss-flink/fluss-flink-common -am -Dtest=TableDescriptorTest,FieldAggregatorParameterizedTest,FlinkAggFunctionParserTest -Dsurefire.failIfNoSpecifiedTests=false test
  • git diff --check
  • mvn -pl fluss-server -DskipTests dependency:tree -Dincludes=org.apache.datasketches
  • npm run build in website parses the updated docs page but fails on pre-existing broken links: /blog/releases/0.9/, /blog/releases/0.8/, and /docs/quickstart/flink/.

AI-assisted changes; draft PR pending human review.

@rahulbsw
rahulbsw marked this pull request as ready for review May 19, 2026 07:58
@rahulbsw rahulbsw mentioned this pull request Nov 9, 2026
Open
platinumhamburg
platinumhamburg requested changes Nov 10, 2026
View reviewed changes

@platinumhamburg platinumhamburg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rahulbsw! The approach looks good overall. Please address the license preservation issue before merging.

Comment thread fluss-server/src/main/resources/META-INF/NOTICE Resolved
Comment thread fluss-server/pom.xml Resolved
Comment thread website/docs/table-design/merge-engines/aggregation.md Resolved
@rahulbsw

rahulbsw commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

The remaining failing check is Java 11 / core:
https://github.com/apache/fluss/actions/runs/42886476405/job/130262605217

The build stops in fluss-flink-2.3 during maven-shade-plugin:3.4.1:shade with Error creating shaded jar: null: NullPointerException. The server module packages successfully; the core test step is skipped because the build fails first. The other reported PR checks, including Java 8 compilation and both Flink test jobs, pass.

The log does not include a stack trace, so the cause is not established. Could a maintainer rerun the failed core job? I attempted gh run rerun 42886476405 --failed, but GitHub refused it with Must have admin rights to Repository. If the failure repeats, a run with Maven -e would help identify its source.

platinumhamburg
platinumhamburg approved these changes Nov 12, 2026
View reviewed changes

@platinumhamburg platinumhamburg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@platinumhamburg
platinumhamburg merged commit 3f37757 into apache:main Nov 12, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@platinumhamburg platinumhamburg platinumhamburg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rahulbsw @platinumhamburg